fix: CassandraProjectionSpec race conditions #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordering issue, the test expected that offsets writing was always completed when the next envelope is processed. Throwing in the event handler can overtake the write since it is run in a stream and errors tearing down the stream is not ordered. * Bonus: added stack traces to integration test failures.
|
Looks like the other projection tests (JdbcProjectionSpec, SlickProjectionSpec, R2dbcProjectionSpec over in r2dbc-plugin) could be making the same assumption about offset commit completing before next envelope is processed. |
johanandren
commented
Dec 1, 2022
akka-projection-cassandra/src/it/scala/akka/projection/cassandra/CassandraProjectionSpec.scala
Outdated
Show resolved
Hide resolved
johanandren
commented
Dec 1, 2022
akka-projection-cassandra/src/it/scala/akka/projection/cassandra/CassandraProjectionSpec.scala
Show resolved
Hide resolved
|
Looked into the JDBC test but touching that triggered other timing sensitive problems, so leaving that and Slick for now as its is this test consistently failing. |
|
Looked into the R2DBC atLeastOnce test cases and I think those are alright because not inspecting offset until end of test cases which should work fine. |
johanandren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #643
Ordering issue, the test expected that offsets writing was always completed when the next envelope is processed. Throwing in the event handler can overtake the write since it is run in a stream and errors tearing down the stream is not ordered.
A
delay(100.millis)between theatLeastOnceHandlerFlowand the downstream ending in offset commit confirms the suspicion by failing the test cases exercising failure